CP-53843: tracing -- link internal subtasks traces#6991
Merged
robhoes merged 1 commit intoApr 15, 2026
Conversation
`exec_with_new_*` function create orphaned traces for subtasks with parents not in the database. This is meant to address this and link these spans to their correct parent. Signed-off-by: Gabriel Buica <danutgabriel.buica@citrix.com>
lindig
approved these changes
Apr 7, 2026
robhoes
approved these changes
Apr 15, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 21, 2026
Builds on top of #6991 The session reuse logic in `xapi_session.ml` does work in this usecase, sm calls are made with `pool=false`. So reimplement the logic so that we use a single session for `sm_exec` per sr. This is achieved by having a hashtable that maps SRs to a corresponding session. The session is created the first time a particular SR needs it and then get reused afterwards. The session gets recreated only if it becomes invalid. This should help the number of database calls during congestion times. Passes BVT and BST.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
exec_with_new_*function create orphaned traces for subtasks with parents not in the database.This is meant to address this and link these spans to their correct parent.